Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClusterFuzzLite in CI featuring PR fuzzing, batch fuzzing and fuzz coverage reports #820

Merged
merged 25 commits into from
Oct 3, 2024
Merged

Add ClusterFuzzLite in CI featuring PR fuzzing, batch fuzzing and fuzz coverage reports #820

merged 25 commits into from
Oct 3, 2024

Conversation

netrome
Copy link
Contributor

@netrome netrome commented Sep 11, 2024 •
edited
Loading

Supersedes #727

This PR introduces fuzzing in our CI using ClusterFuzzLite, roughly following the instructions outlined in the ClusterFuzzLite Github Actions docs.

Before requesting review

  • I have reviewed the code myself

@netrome netrome mentioned this pull request Sep 11, 2024
Closed
@netrome netrome self-assigned this Sep 11, 2024
@mchristopher mchristopher mentioned this pull request Sep 24, 2024
Closed
10 tasks
@netrome netrome force-pushed the chore/tob-fuzzer-clusterfuzzlite branch 5 times, most recently from dec93b6 to 6173289 Compare September 27, 2024 07:17
@netrome netrome marked this pull request as ready for review September 30, 2024 06:52
@netrome netrome force-pushed the chore/tob-fuzzer-clusterfuzzlite branch from 3d3a759 to 2d846dd Compare September 30, 2024 06:54
@netrome netrome requested a review from a team October 1, 2024 11:13
xgreenx
xgreenx approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to verify somehow that if fuzzers fails, it will report about it. Could you try to introduce a bug in a separate PR which fuzzer will catch, please?=)

@netrome netrome requested a review from a team October 2, 2024 06:51
@netrome
Copy link
Contributor Author

netrome commented Oct 2, 2024

It would be nice to verify somehow that if fuzzers fails, it will report about it. Could you try to introduce a bug in a separate PR which fuzzer will catch, please?=)

We had some fun doing this in this PR. Posting here for visibility: #846

@netrome netrome added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit 9693d43 Oct 3, 2024
40 checks passed
@netrome netrome deleted the chore/tob-fuzzer-clusterfuzzlite branch October 3, 2024 14:03
@xgreenx xgreenx mentioned this pull request Oct 5, 2024
Merged
@maxammann
Copy link
Contributor

@netrome Hi! Would you be open to chat about how this works our for Fuel in a few months from now?

@netrome
Copy link
Contributor Author

netrome commented Oct 10, 2024

@netrome Hi! Would you be open to chat about how this works our for Fuel in a few months from now?

Sure thing, I'd be happy to. Right now we're experiencing some issues with empty coverage uploads https://github.com/FuelLabs/fuel-fuzzing-corpus/commit/bf288985f3b94e8048d36b457c750cf7af6865b5 is that anything you recognize from other projects?

@maxammann
Copy link
Contributor

@netrome Hi! Would you be open to chat about how this works our for Fuel in a few months from now?

Sure thing, I'd be happy to. Right now we're experiencing some issues with empty coverage uploads FuelLabs/fuel-fuzzing-corpus@bf28898 is that anything you recognize from other projects?

Sadly does not ring a bell for me :/

@netrome
Copy link
Contributor Author

netrome commented Oct 15, 2024

Sadly does not ring a bell for me :/

Oh well, we'll figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

@AurelienFT AurelienFT AurelienFT approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

Assignees

@netrome netrome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@netrome @maxammann @xgreenx @AurelienFT @mchristopher